Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

fix: Do not auto-convert string values to boolean COMPASS-4466 #221

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

rose-m
Copy link
Contributor

@rose-m rose-m commented Nov 12, 2020

Description

In the past Compass automatically converted string values that matched "0", "1", "false", "true", "FALSE", "TRUE", "", "null", "NULL" to the boolean true or false during exporting to CSV.

This conversion is now disabled and the values are exported as they are. Only "real" boolean values will be exported as true or false. This is in line with the behavior of mongoexport.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@rose-m rose-m self-assigned this Nov 12, 2020
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! nice work finding the bug too.

data exporting
Screen Shot 2020-11-12 at 11 50 51 AM
resulting csv (empty string on first line 👍 )
Screen Shot 2020-11-12 at 11 50 23 AM

@rose-m rose-m merged commit 9b54b9c into master Nov 12, 2020
@rose-m rose-m deleted the COMPASS-4466-no-export-boolean-autoconversion branch November 12, 2020 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants