Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

COMPASS-3949: buttons based on current import state #13

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Conversation

lrlna
Copy link
Contributor

@lrlna lrlna commented Nov 1, 2019

Description

Configures import buttons based on current import state.

  • Cancel and Import are present when file is not yet imported
  • Close and Import are present when file import was stopped
  • ...Importing is present as disabled when file is in the middle of import
  • Stop anchor link is present along with a progress bar
  • Done button is present after import successfully completed

Result looks like this:
MOgeOInbOd

Types of changes

  • Patch (non-breaking change which fixes an issue)

@lrlna lrlna requested review from imlucas and sampoonachot November 1, 2019 12:41
@sampoonachot
Copy link

The buttons look great!

A fit spacing adjustments:

  1. Can we extend the progress par so it aligns with the content above it?
  2. Then reduce the padding between the bottom of the progress indicator and the HR line, so that it matches the padding between the HR line and the bottom buttons?

Screen Shot 2019-11-01 at 9 47 02 AM

@lrlna
Copy link
Contributor Author

lrlna commented Nov 1, 2019

@sampoonachot yes! done

@imlucas imlucas merged commit 5fe5a9c into master Nov 1, 2019
@lrlna lrlna deleted the COMPASS-3949 branch November 4, 2019 11:48
@lrlna
Copy link
Contributor Author

lrlna commented Nov 4, 2019

📦 4.1.5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants