This repository was archived by the owner on May 17, 2021. It is now read-only.
chore: remove data-service-initialized event COMPASS-4568
#252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2021
addaleax
approved these changes
Jan 18, 2021
Anemy
force-pushed
the
COMPASS-4568/remove-data-service-initialized-event
branch
from
690ac48 to
941e5c8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were sending the data service with the
data-service-initializedevent. This event would pass a connection which is not guaranteed to successfully connect, and keeping it around in other plugins will cause unexpected errors. This PR removes thedata-service-initializedevent to avoid using an unreliable connection.PRs this depends on before merging to Compass:
data-service-initializedtodata-service-connectedevent COMPASS-4568 compass-deployment-awareness#183data-service-initializedtodata-service-connectedevent COMPASS-4568 compass-instance-header#131data-service-initializedtodata-service-connectedevent COMPASS-4568 compass-sidebar#154