This repository was archived by the owner on May 17, 2021. It is now read-only.
fix: Hide progress bar on invalid connection string connect attempt COMPASS-4202 #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jan 12, 2021
src/stores/index.js
Outdated
| } | ||
|
|
||
| this.StatusActions.done(); |
There was a problem hiding this comment.
Would try ... finally ... make sense here?
There was a problem hiding this comment.
Good thinking - updated - added test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-4202
Bug was caused by starting the
showIndeterminateProgressBarbut never hiding it on validation error. The validation error which disables theconnectbutton is debounced and async also so it doesn't always prevent the user from trying to connect to an invalid connection string. This pr now fixes the handling of those invalid connection attempts.Here's what the previous infinite loading looks like now (testing new mp4 functionality in vscode 🤔 ):
connecting-to-non-existant-freezes-ui.mp4