Add libass support!

[vegedb]

https://github.com/libass/libass

As you can see, its weird not to see Just Player in here seeing its open sourced like the others.
ASS/SSA subs is the only thing missing for Just player. Particularly for Anime fans!

Hope you could add it too!

[moneytoo]

This is a job for ExoPlayer: google/ExoPlayer#8435 (comment)

[vegedb]

@moneytoo
Its an entirely separate entity from exoplayer. Emby and plex (recently added libass) android players both use exoplayer and libass on top of it.

Hope you can look it up.

[vegedb]

https://libass.github.io/JavascriptSubtitlesOctopus/videojs.html
https://libass.github.io/JavascriptSubtitlesOctopus/index.html

Here are some JS examples on browser players using libass.

[vegedb]

Configuring subtitle renderer possible in Just player?

Libass is an open source subtitle renderer and a replacement for the VSfilter.

Example,

1. on MPC-HC, you could change it by pointing to a folder with libass.
2. on MPV, you could point a "script" folder with latest libass

[moneytoo]

If there were any publicly available patches/integration of libass in ExoPlayer, I would include them. Unfortunately, no one is sharing that. It would be needed to be implemented in the engine so it's really not a task for Just Player.

[moneytoo]

As there is already the peerless2012/libass-android library, here's a test build of Just Player with it: https://brouken.com/player/libass/
It's not compatible with latest Media3 alphas and it causes some issues with non-ASS videos but feel free to try it.

[peerless2012]

As there is already the peerless2012/libass-android library, here's a test build of Just Player with it: https://brouken.com/player/libass/ It's not compatible with latest Media3 alphas and it causes some issues with non-ASS videos but feel free to try it.

Already fixed, and external ass subtitle supported, check release.

Hope this can help you, if you have any issue, create an issue, pr is also great.

[TheDcoder]

@moneytoo I tried the libasss-v0.191 branch and the results so far are not satisfactory. Compared to the vanilla player I noticed the following differences:

1. The font is "thin", I have bold fonts enabled in the settings.
2. The embedded font is not used, rather some generic fallback is being used, it's not as nice as the vanilla font, the edges are very jagged.
3. Since the embedded font is not used, the fallback is too large and falls out of alignment (it starts to overlap with hardcoded subtitles).
4. Not quite sure what happened but subtitles stopped working entirely after I accidentally closed the player and reopened it quickly within 5 seconds, changing the subtitles and turning them on or off had no effect. I had to completely close out of it again and then restart the video to make the subtitles work.

[TheDcoder]

Noticed another major bug, HDR/Dolby Vision has stopped working in this build, the TV is not getting the HDR metadata. It used to work perfectly fine in the previous stable release.

[peerless2012]

@moneytoo I tried the libasss-v0.191 branch and the results so far are not satisfactory. Compared to the vanilla player I noticed the following differences:

1. The font is "thin", I have bold fonts enabled in the settings.
2. The embedded font is not used, rather some generic fallback is being used, it's not as nice as the vanilla font, the edges are very jagged.
3. Since the embedded font is not used, the fallback is too large and falls out of alignment (it starts to overlap with hardcoded subtitles).
4. Not quite sure what happened but subtitles stopped working entirely after I accidentally closed the player and reopened it quickly within 5 seconds, changing the subtitles and turning them on or off had no effect. I had to completely close out of it again and then restart the video to make the subtitles work.

1. The font is "thin", I have bold fonts enabled in the settings.

Customer font style is not support now.

2. The embedded font is not used, rather some generic fallback is being used, it's not as nice as the vanilla font, the edges are very jagged.

The embedded font in mkv should work, what's format of your file?

3. Since the embedded font is not used, the fallback is too large and falls out of alignment (it starts to overlap with hardcoded subtitles).

Share the file, and I can make a test.

4. Not quite sure what happened but subtitles stopped working entirely after I accidentally closed the player and reopened it quickly within 5 seconds, changing the subtitles and turning them on or off had no effect. I had to completely close out of it again and then restart the video to make the subtitles work.

And tell me how to reproduce this issue.

[peerless2012]

Noticed another major bug, HDR/Dolby Vision has stopped working in this build, the TV is not getting the HDR metadata. It used to work perfectly fine in the previous stable release.

My test dv mkv works fine on my pad, is this only for some file or all file?