Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precise money #335

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Precise money #335

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
529b532
Copy functionality of Money to PreciseMoney
frederikbosch Nov 29, 2016
6e12489
Add spec tests for PreciseMoney
frederikbosch Nov 29, 2016
f73f3ca
construct decimals
frederikbosch Nov 29, 2016
633da38
add numbers precisely
frederikbosch Nov 29, 2016
faa126a
divide and multiply precise money
frederikbosch Nov 29, 2016
0d9be3a
style and bug fixes
frederikbosch Nov 29, 2016
47cfa2f
style and bug fixes
frederikbosch Nov 29, 2016
7e2b0cd
remove php calculator from precise money
frederikbosch Nov 29, 2016
cf3620e
fixes php 5 and hhvm
frederikbosch Nov 29, 2016
179ab79
never divide by zero in tests
frederikbosch Nov 29, 2016
139c346
fix php 5.5 and hhvm
frederikbosch Nov 29, 2016
212101d
Fix comparison operation
flajos Sep 14, 2017
85ba0d0
Merge pull request #402 from flajos/patch-1
sagikazarmark Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix php 5.5 and hhvm
  • Loading branch information
@frederikbosch
frederikbosch committed Nov 29, 2016
commit 139c34617bc761e9854c5e4561e68d69840fbd6b
4 changes: 2 additions & 2 deletions src/Calculator/GmpCalculator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ public function add($amount, $addend)

$integer = gmp_add($amount->getIntegerPart(), $addend->getIntegerPart());
if ($amount->isInteger()) {
return (string) $integer.'.'.$addend->getFractionalPart();
return gmp_strval($integer).'.'.$addend->getFractionalPart();
}

if ($addend->isInteger()) {
return (string) $integer.'.'.$amount->getFractionalPart();
return gmp_strval($integer).'.'.$amount->getFractionalPart();
}

$largestDigits = max(strlen($amount->getFractionalPart()), strlen($addend->getFractionalPart()));
Expand Down