Clarify warning about too-few blocks #9483
Open
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffro256
reviewed
Sep 17, 2024
philipmw
force-pushed
the
blocks-checked
branch
from
e5c09dd
to
6bc48a1
Compare
philipmw
force-pushed
the
blocks-checked
branch
from
6bc48a1
to
ddc2d80
Compare
sneurlax
approved these changes
Oct 1, 2024
iamamyth
reviewed
Oct 19, 2024
Today, the warning about too-few blocks is not clear about what happened versus what was expected; that's the main thing I want to address. Clarifying this makes the message somewhat longer, so I reduce its length by removing some redundant or meaningless (IMO) reasons for the symptoms.
philipmw
force-pushed
the
blocks-checked
branch
from
ddc2d80
to
a4cfebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the warning about too-few blocks is not clear about what happened versus what was expected; that's the main thing I want to address.
Clarifying this makes the message somewhat longer, so I reduce its length by removing some redundant or meaningless (IMO) reasons for the symptoms.