Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: remove CMD line and docker-compose file provided #9391

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dockerfile: remove CMD line and docker-compose file provided #9391

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0148712
Dockerfile: remove CMD line and docker-compose file provided
Jul 3, 2024
2b63c20
docker-compose: comment --log-level=4 command for performace issue an…
Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,3 @@ EXPOSE 18081
USER monero

ENTRYPOINT ["monerod"]
CMD ["--p2p-bind-ip=0.0.0.0", "--p2p-bind-port=18080", "--rpc-bind-ip=0.0.0.0", "--rpc-bind-port=18081", "--non-interactive", "--confirm-external-bind"]

36 changes: 36 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
services:
monero:
container_name: monero
build:
context: .
restart: always
ports:
- 18080:18080
- 18081:18081
- 18082:18082
- 18083:18083
- 18084:18084
command:
- --p2p-bind-ip=0.0.0.0
- --p2p-bind-port=18080
- --rpc-bind-ip=0.0.0.0
- --rpc-bind-port=18081
- --non-interactive
- --rpc-ssl=disabled
- --disable-rpc-ban
- --confirm-external-bind
- --zmq-pub=tcp://0.0.0.0:18084
- --zmq-rpc-bind-port=1882
- --zmq-rpc-bind-ip=0.0.0.0
- --log-level=4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why --rpc-ssl=disabled? Also --log-level=4 is too high, it will cause performance issues due to massive amount of logs written.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a template for development and everyone could modify them by their needs. I think Server-side services communicate under the Docker network by service name in most cases and SSL isn't required between them.
However, it seems it's better to change them let me remove these and add some comments from "monerod --help" to it.

volumes:
- bitmonero:/root/.bitmonero
networks:
- monero

volumes:
bitmonero: {}

networks:
monero:
driver: bridge
Loading