-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
external: update miniupnpc 2.2.8 #9367
base: master
Are you sure you want to change the base?
external: update miniupnpc 2.2.8 #9367
Conversation
1. LINKS flag, will link publicly the libraries provided. 2. PRIVATE_LINKS flag, will link privately the libraries provided. 3. INCLUDES flag, will includes publicly the dirs provided. 4. PRIVATE_INCLUDES flag, will include privately the libraries provided.
@0xFFFC0000 any update on this? |
It is ready, has been since its release. Needs reviews. |
@@ -35,8 +35,13 @@ | |||
# ...except for FreeBSD, because FreeBSD is a special case that doesn't play well with | |||
# others. | |||
|
|||
if(NOT MSVC) | |||
add_compile_options(-D_GNU_SOURCE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed since we add _GNU_SOURCE
to compile options in the root CMakeLists.txt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, since we add it to CMAKE_C_FLAGS
[1] and it does not pass it to projects added via add_subdirectory
. It fixes this build issue [2].
Fix and improve existing CMake script.
Fixes: #9359
Related: #9366