external: update miniupnpc 2.2.8 #9367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. LINKS flag, will link publicly the libraries provided. 2. PRIVATE_LINKS flag, will link privately the libraries provided. 3. INCLUDES flag, will includes publicly the dirs provided. 4. PRIVATE_INCLUDES flag, will include privately the libraries provided.
5 tasks
|
@0xFFFC0000 any update on this? |
It is ready, has been since its release. Needs reviews. |
jeffro256
reviewed
Aug 28, 2024
| @@ -35,8 +35,13 @@ | |||
| # ...except for FreeBSD, because FreeBSD is a special case that doesn't play well with | |||
| # others. | |||
|
|
|||
| if(NOT MSVC) | |||
| add_compile_options(-D_GNU_SOURCE) | |||
There was a problem hiding this comment.
Is this needed since we add _GNU_SOURCE to compile options in the root CMakeLists.txt?
There was a problem hiding this comment.
Yes, since we add it to CMAKE_C_FLAGS [1] and it does not pass it to projects added via add_subdirectory. It fixes this build issue [2].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and improve existing CMake script.
Fixes: #9359
Related: #9366