Fix lmdb txn commit code #9290
Open
Fix lmdb txn commit code #9290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM semantically and syntactically. I will approve this in few days if anyone not raise any issues about having this here. |
|
Embarrassing, this still has a bug in it. I will post an updated version, with an additional fix for the |
vtnerd
force-pushed
the
fix/lmdb_txn_commit
branch
from
ee93014
to
d64a5f7
Compare
|
@0xFFFC0000 sorry for the changes, but I added a few more. If they get accepted, I will do a release branch version too. LWS is a little "shaky" without the changes. |
This was referenced Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added LMDB code to monero core a while ago. The only project (afaik) using it is LWS. I found this bug in the commit code - commit can fail with a resize request too.
If anyone thinks this code should be removed and put into LWS let me know shortly. I thought perhaps this could be used to replace existing LMDB code, but it looks unlikely at this point.