Non-portable type used in wire protocol definition

[iamsmooth]

Similar to issue #88, connection_entry in p2p_protocol_defs.h contains is_income (misspelling of is_incoming I believe) which is defined as a bool. The size of bool is implementation-defined.

Fortunately connection_entry is only used for node debugging, which we may not even have enabled. Nevertheless the code should be fixed if it isn't going to be removed.

[moneromooo-monero]

I think this is invalid, as the struct is not written as is, but the fields are serialized independently, and bool has an overload in the serialization code.

[iamsmooth]

Quite possible. Where is this overload?

[moneromooo-monero]

It's in the list of handled types in:
struct base_serializable_types: public boost::mpl::vector<uint64_t, uint32_t, uint16_t, uint8_t, int64_t, int32_t, int16_t, int8_t, double, bool, std::string, typename t_storage::meta_entry>::type
but after that, I can't follow the serialize template code to know exactly where it does. I suspect serialize_int, but I'm not sure.