Set CURLOPT_HTTP09_ALLOWED to true #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code is old and is to be replaced by #154. |
|
I'll just patch it until the release then @recanman. But wouldn't this still be good to merge as it's such a small non breaking change, and we don't know when the new version is going to be replaced. If people wanna use it and have a newer cURL version, they literally can't use it without the patch. |
|
Good point. I don't have write access and I cannot merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURL allowed HTTP/0.9 responses by default before 7.66.0, but since 7.66.0, libcurl requires this option set to 1L to allow HTTP/0.9 responses. This is required for interacting with Monero wallet as it uses HTTP/0.9.
https://curl.se/libcurl/c/CURLOPT_HTTP09_ALLOWED.html