chore: optimize rendering code #236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in struct name and all related function signatures to use the correct name. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove duplicate optimization code from ui/screen.go, ui/tcell.go, and app/dry.go. This restores the original implementation to prepare for proper migration strategy. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add ScreenRenderer interface to enable both Screen and OptimizedScreen implementations. Update method signatures to return interface type for compatibility during migration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add NewScreenWithOptimization function that can switch between Screen and OptimizedScreen implementations based on UseOptimizedScreen flag. This enables gradual rollout testing. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add --optimized-screen flag to enable testing of optimized screen implementation. Currently limited to Screen implementation due to interface compatibility requirements. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add compatibility methods to screen wrapper to satisfy appui.ScreenBuffererRender interface requirements after ScreenRenderer interface introduction. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add missing newlines and fix formatting per make fmt requirements. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an optional OptimizedScreen implementation with finer-grained locking and lock-free fast paths, refactors the original Screen to a ScreenRenderer interface, and adds a CLI flag to toggle optimization.
- Add
OptimizedScreenwith separate render/config locks and atomic fields - Define
ScreenRendererinterface and factoryNewScreenWithOptimization - Update
main.goandapp/dry.goto wire up the new implementation and CLI flag
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/screen_optimized.go | New OptimizedScreen implementation using separate locks & atomic |
| ui/screen.go | ScreenRenderer interface definition, update Screen methods |
| main.go | Add --optimized-screen flag, use factory and type assertion |
| app/dry.go | Adapt wrapper methods to new interface |
| SCREEN_OPTIMIZATION.md | Documentation on lock contention fix and migration guide |
| CLAUDE.md | AI guidance file (unrelated to core rendering functionality) |
Comments suppressed due to low confidence (1)
SCREEN_OPTIMIZATION.md:22
- The doc mentions a
stateLockfield that doesn't exist inOptimizedScreen. Update this section to reflect the actual fields (renderLock,configLock, atomicclosinganddimensions).
stateLock sync.RWMutex // For closing and dimensions (unused now)
Comment on lines
+224
to
+225
| screen.screen.SetCell(x, y, style, r) | ||
| screen.renderLock.Unlock() |
There was a problem hiding this comment.
[nitpick] Consider using defer screen.renderLock.Unlock() immediately after Lock() for consistency and to prevent lock leaks if future code panics or returns early.
Suggested change
| screen.screen.SetCell(x, y, style, r) | |
| screen.renderLock.Unlock() | |
| defer screen.renderLock.Unlock() | |
| screen.screen.SetCell(x, y, style, r) |
| fg, bg := screen.theme.Fg, screen.theme.Bg | ||
| screen.configLock.RUnlock() | ||
|
|
||
| st := mkStyle(termbox.Attribute(fg), termbox.Attribute(bg)) |
There was a problem hiding this comment.
[nitpick] Mixing termbox.Attribute with tcell.Style may be confusing. Consider centralizing attribute-to-style conversion in one helper or using consistent tcell color types.
Add delegation wrapper that allows OptimizedScreen to work seamlessly with existing codebase that expects *ui.Screen. Key optimized methods are delegated to OptimizedScreen implementation when --optimized-screen flag is used. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.