Push explicitly specified tags to Docker (appsmithorg#2988)

* Push explicitly specified tags to Docker * Remove now stale comments
monarch0111 · Feb 11, 2021 · 215f1ed · 215f1ed
1 parent 8aa39ea
commit 215f1ed
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/.github/workflows/server.yml b/.github/workflows/server.yml
@@ -95,9 +95,7 @@ jobs:
       run: |
         docker build --build-arg APPSMITH_SEGMENT_CE_KEY=${{ secrets.APPSMITH_SEGMENT_CE_KEY }} -t ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-server:${{steps.vars.outputs.tag}} .
         echo ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin
-        # This command pushes all the tags on the machine to Docker hub. This has been written for ease of reading. Be very careful
-        # with this command
-        docker push ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-server
+        docker push ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-server:${{steps.vars.outputs.tag}}
 
     # Build master Docker image and push to Docker Hub
     - name: Push master image to Docker Hub with commit tag
@@ -106,9 +104,8 @@ jobs:
         docker build --build-arg APPSMITH_SEGMENT_CE_KEY=${{ secrets.APPSMITH_SEGMENT_CE_KEY }} -t ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-server:${GITHUB_SHA} .
         docker build --build-arg APPSMITH_SEGMENT_CE_KEY=${{ secrets.APPSMITH_SEGMENT_CE_KEY }} -t ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-server:nightly .
         echo ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin
-        # This command pushes all the tags on the machine to Docker hub. This has been written for ease of reading. Be very careful
-        # with this command
-        docker push ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-server
+        docker push ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-server:${GITHUB_SHA}
+        docker push ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-server:nightly
 
   # These are dummy jobs in the CI build to satisfy required status checks for merging PRs. This is a hack because Github doesn't support conditional
   # required checks in monorepos. These jobs are a clone of similarly named jobs in client.yml.