Skip to content

Commit

Permalink
Get module building working with MSVC
Browse files Browse the repository at this point in the history
MSVC doesn't like the way we're #include-ing flux.hpp within the module purview, although it seems to work correctly, so we'll silence the warning.
  • Loading branch information
tcbrindle committed Jul 28, 2023
1 parent db27f40 commit 1864f09
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion module/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,11 @@
include(modules)

add_module_library(flux-mod flux.cpp)
target_link_libraries(flux-mod PRIVATE flux)
target_link_libraries(flux-mod PUBLIC flux)

# Squish MSVC warning when building the module, hopefully we're not actually doing anything wrong
if(MSVC)
target_compile_options(flux-mod PRIVATE
/wd5244 # '#include <flux.hpp>' in the purview of module 'flux' appears erroneous
)
endif()

0 comments on commit 1864f09

Please sign in to comment.