Skip to content

fix Deno serve registration ordering - #376

Merged
momics merged 1 commit into
mainfrom
codex/release-0.6-deno-serve-readiness
Jul 18, 2026
Merged

fix Deno serve registration ordering#376
momics merged 1 commit into
mainfrom
codex/release-0.6-deno-serve-readiness

Conversation

@momics

@momics momics commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve JS call order across Deno’s asynchronous serveStart bridge so immediate self-fetch observes the server just started
  • order immediate stop and endpoint close behind registration, and drain tracked stop ops before lifecycle completion
  • make the shared stale-handle assertion portable to Tauri’s scalar equality helper without weakening the check

Failures addressed

Exact-SHA Extended Tests on 193a6ff found:

  • Deno: node can fetch its own node id while serving failed because fetch overtook native serve registration
  • Tauri: the stale-handle stress assertion compared two distinct arrays under a scalar-only harness, so an empty error list falsely failed

Node passed that same run.

Validation

  • full rebuilt Deno suite: 88/88, twice
  • immediate Deno self-fetch stress: 25/25
  • Deno serve/lifecycle focus with op sanitizers: 14/14
  • Tauri guest tests: 86/86
  • all workspace TypeScript typechecks
  • Deno check and configured fmt check
  • two independent lifecycle reviews: clean

@momics
momics merged commit 6f57a92 into main Jul 18, 2026
8 checks passed
@momics
momics deleted the codex/release-0.6-deno-serve-readiness branch July 18, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant