fix adapter cancellation ownership races - #375
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stopServe()after native serve registration so lifecycle shutdown cannot be lostpathChanges()iterator an adapter subscription ID and use one token-aware core watcher to fan out per peerWhy
The exact-SHA extended run for
c828112exposed two bridge scheduling races: Tauri could lose a stop before serve registration, and Node could lose an abort before the native path subscription existed. A first adapter-only ownership pass was rejected during review because core still owned one peer-wide sender. This version fixes ownership at the source while retaining exactly one polling watcher per peer.Validation
cargo test -p iroh-http-core --test observe(3/3)