Skip to content

fix(deps): clear undici & js-yaml npm audit advisories - #239

Merged
momics merged 1 commit into
mainfrom
fix/npm-audit-advisories
Jun 25, 2026
Merged

fix(deps): clear undici & js-yaml npm audit advisories#239
momics merged 1 commit into
mainfrom
fix/npm-audit-advisories

Conversation

@momics

@momics momics commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Closes #238.

What

npm audit fix to clear two pre-existing advisories that fail the CI npm audit --audit-level=high gate (also red on main today, independent of the iroh 1.0 upgrade in #236).

Package Before After Severity Path
undici 7.25.0 7.28.0 high (GHSA-35p6-xmwp-9g52 + others) dev dep of @momics/iroh-http-tauri
js-yaml 4.1.1 4.2.0 moderate (GHSA-h67p-54hq-rp68) via @napi-rs/cli build tooling

Scope & safety

  • Lockfile-only change (package-lock.json); no package.json edits.
  • Both are transitive dev/build-time deps — no runtime exposure.
  • npm audit fix (non---force) → semver-compatible bumps only.

Validation

  • npm audit --audit-level=high0 vulnerabilities.
  • node scripts/check-lockfile.mjs → 187 entries, all valid.
  • npm run typecheck → clean across all workspaces.
  • Full build/test/e2e matrix runs in CI.

Follow-up

Once merged, main is merged into feature/iroh-1.0-upgrade so the Verify job on #236 goes green, unblocking the iroh 1.0 major release (#237).

npm audit fix resolves two pre-existing dev-tooling advisories:
- undici 7.25.0 -> 7.28.0 (high: GHSA-35p6-xmwp-9g52 et al.)
- js-yaml 4.1.1 -> 4.2.0 (moderate: GHSA-h67p-54hq-rp68)

Both are transitive dev/build-only deps (undici via the Tauri test
package, js-yaml via @napi-rs/cli). Lockfile-only change; npm audit
now reports 0 vulnerabilities.

Refs #238
@momics
momics merged commit 192fb53 into main Jun 25, 2026
6 checks passed
@momics momics mentioned this pull request Jun 25, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate undici advisory flagged by npm audit (via jsdom dev dep)

1 participant