Summary
maxServeErrors is documented as "consecutive accept-loop errors before the serve loop terminates (default 5)" and is plumbed from the JS API through the adapters into core ServeOptions — but it has no consumer in the accept loop. Verified: the only references in the core crate are the options-struct field and a defaults test; the accept loop has no consecutive-error termination.
Evidence
Impact
Low — a documented reliability knob is a no-op; the accept loop retries forever regardless of the setting.
Remediation
- Either wire it into the accept loop's consecutive-error counter so the loop terminates after N errors as documented, OR remove it from the API/docs and note the behavior (loop retries forever).
Acceptance criteria
maxServeErrors either has an observable effect (test proves termination after N errors) or is removed from the API and docs.
Summary
maxServeErrorsis documented as "consecutive accept-loop errors before the serve loop terminates (default 5)" and is plumbed from the JS API through the adapters into coreServeOptions— but it has no consumer in the accept loop. Verified: the only references in the core crate are the options-struct field and a defaults test; the accept loop has no consecutive-error termination.Evidence
max_serve_errors: Option<usize>, "Default: 5").max_serve_errors/serve_errorsinaccept.rs/server.rs.Impact
Low — a documented reliability knob is a no-op; the accept loop retries forever regardless of the setting.
Remediation
Acceptance criteria
maxServeErrorseither has an observable effect (test proves termination after N errors) or is removed from the API and docs.