Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Error & Maintenance Pages #538

Merged
merged 3 commits into from
Dec 11, 2021
Merged

Conversation

glassglue
Copy link
Contributor

@glassglue glassglue commented Aug 16, 2021

Closes #356
Closes #528.
This updates the 404 page to have the text be visible (yay)! Preview shown below:
image
I tried to make it as 1:1 with the render as possible - the black bar definitely helps quite a bit here.

As for the 502 page, I recreated a 'lite' version of the 404 page - because there is no button component needed, some tweaking was done. I opted to not include the gradient as I felt we wanted this page to be pretty light as-is, but it's a very quick implementation if needed. Stylistically this file fought me quite a bit (certain CSS properties didn't want to inherent correctly) so any suggestions for improvement here would be appreciated
image

@Gocnak
Copy link
Member

Gocnak commented Aug 17, 2021

Could you squash 4e18d55 into e130a3e ?

@bakapear
Copy link
Contributor

bakapear commented Aug 17, 2021

Issues:

404 - Background size not consistent

(Also the scrollbar shows all the time)
Hectorsdolphin_35318+ x +(2021-08-17+at+09 21 58)

502 - Not responsive at all

image

502 - Custom font not loading

Gotta add the Bebas Neue font to the maintenance folder too, I think.

Suggestions:

502 - More user-friendly title message

(Add Error Code: 404 to 404 page aswell then)
image

502 - Optional Discord button

Might be too much for a simple 502 but idk
image

Background gradient

I do prefer the non-gradient look on the server message pages but it IS a little too bright without it in my opinion (probably just me because I have everything on windows set to darkmode). Maybe change the gradient to be a consistent darker overlay.
image

@glassglue
Copy link
Contributor Author

glassglue commented Aug 17, 2021

Thanks for all the tips! I'm gonna be a bit AFK (moving time), but I will crack away at these suggestions. As it stands, I'm looking into the 404 page's scrollbar issue, but I pushed a commit that covers quite a few of the issues/suggestions.

I like the 'page under maintenance' as the header waaaay better, users probably don't know/care about error codes. I'll take a look into the discord button idea.

Quick thoughts: do we want to keep letter-spacing at 0.8rem? Given how much longer the header is compared to the 404 page, I thought it might look better at 0.4 (shown below)
image

I pushed my current commit just so everyone can see how the current site looks after fixes so more discussion can be had- will rebase before merge. Pictures in PR updated with current commit

background SCSS optimized, gradient implemented, 'black bar' implemented
basic maintenance implementation

font gradients needs to be set properly
sizing fixes, font changes
-responsiveness added to text objects on the 502 page - given the length of the header, this seems to scale differently than the 404 but it's the same
-min-height added to prevent the black bar from disappearing on rescales
-quick font fix and gradient implementation
-restructured the HTML file for simplicity
@glassglue
Copy link
Contributor Author

glassglue commented Aug 17, 2021

One more thing - I looked into removing the scrollbar from the 404 page, but I believe it's due to the use of <nb-layout>. This is supported by the issue not being present on the 502.html document as it can't use that tag. I'll look into messing with this as overflow does nothing in this instance.

As discussed above, here's an example of both top and bottom gradients - thoughts?
image

@bakapear
Copy link
Contributor

Good idea to reduce the letter spacing on the header. It's quite long.

I think there is still some tweaking with the background you could still do:

The background height shouldn't change size here

Preview

It would also probably be better if the background size is changed with the width breakpoints

Preview

I have a commit here 3373c86 which resolves both of these (by just changing CSS that adds a background color to the text div block instead of adding a new html tag for the background itself).

The top and bottom gradients look a bit too dark for me now but otherwise it's fine!

As for the scrollbar issue- it occurs on every page. That would need to be fixed in a separate PR as it's not related to only error pages.

@glassglue
Copy link
Contributor Author

glassglue commented Sep 7, 2021

Back from the hiatus!
In one of the team meetings, it was discussed that switching this to the black background would be aesthetically superior, so I will be reformatting both versions to work with this - it might also solve the gradient dilemma. I'll put a preview below when I have something ideal.

I'll add that commit that fixes those nasty issues as well - thanks for that!

@Hona Hona changed the title Fix/error pages 💄 Error & Maintenance Pages Nov 5, 2021
@Hona Hona added the Blocked: Needs more work This needs more work to be able to be accepted label Nov 19, 2021
@Hona
Copy link
Contributor

Hona commented Nov 19, 2021

How are you going with this @wallenben

@glassglue
Copy link
Contributor Author

I added bakapear's fixes to this which solved the aforementioned sizing issues neatly. For posterity, the added commits make the pages look like so:
chrome_uuf6ug6l2e

chrome_Kjdky2q2ub

Couldn't find much on the scrollbar thing, but I'll keep looking to see what can be done.

Copy link
Member

@Gocnak Gocnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scroll issue was fixed in #566 so this should be good!

@Gocnak Gocnak merged commit cd5db89 into momentum-mod:staging Dec 11, 2021
@Gocnak Gocnak removed the Blocked: Needs more work This needs more work to be able to be accepted label Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 page has poor visibility with new background image Custom maintenance page
4 participants