-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Error & Maintenance Pages #538
Conversation
Issues:502 - Custom font not loadingGotta add the Suggestions: |
background SCSS optimized, gradient implemented, 'black bar' implemented basic maintenance implementation font gradients needs to be set properly sizing fixes, font changes
4e18d55
to
df83cd5
Compare
-responsiveness added to text objects on the 502 page - given the length of the header, this seems to scale differently than the 404 but it's the same -min-height added to prevent the black bar from disappearing on rescales -quick font fix and gradient implementation -restructured the HTML file for simplicity
Good idea to reduce the letter spacing on the header. It's quite long. I think there is still some tweaking with the background you could still do: I have a commit here 3373c86 which resolves both of these (by just changing CSS that adds a background color to the text div block instead of adding a new html tag for the background itself). The top and bottom gradients look a bit too dark for me now but otherwise it's fine! As for the scrollbar issue- it occurs on every page. That would need to be fixed in a separate PR as it's not related to only error pages. |
Back from the hiatus! I'll add that commit that fixes those nasty issues as well - thanks for that! |
How are you going with this @wallenben |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scroll issue was fixed in #566 so this should be good!
Closes #356

Closes #528.
This updates the 404 page to have the text be visible (yay)! Preview shown below:
I tried to make it as 1:1 with the render as possible - the black bar definitely helps quite a bit here.
As for the 502 page, I recreated a 'lite' version of the 404 page - because there is no button component needed, some tweaking was done. I opted to not include the gradient as I felt we wanted this page to be pretty light as-is, but it's a very quick implementation if needed. Stylistically this file fought me quite a bit (certain CSS properties didn't want to inherent correctly) so any suggestions for improvement here would be appreciated
