Drastically improve perf with memoize #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Looks good! I knew we would have to add memoization at some point as these methods have quite a bit of computation involved. Thanks for tackling this. |
timrwood
added a commit
that referenced
this pull request
Oct 17, 2013
Drastically improve perf with memoize
|
🎆 |
jlfwong
added a commit
to UWFlow/rmc
that referenced
this pull request
Nov 18, 2013
This comes with a huge perf boost due to memoization! See: moment/moment-timezone#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using moment by itself for a project and then added moment-timezone and noticed a huge performance degradation. After some profiling and digging I noticed that many of the moment-timezone functions could and should be memoized. After applying this patch to my own project, performance returned to how it was pre-moment-timezone. The test speed is also very telling...
before
>> 103487 assertions passed (63010ms) Done, without errors.after
>> 103487 assertions passed (18811ms) Done, without errors.Furthermore, this speed difference is even more apparent in real world use cases were most computing is done in a single, relevant timezone.
Thanks for all the work put into this, timezones are a nightmare...