Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #1097
@gpaucot Added some commits:
toSQLDate
andtoSQLTime
. So I set up both your fully-inlined one and my refactor and benchmarked them against each other, then tweaked mine until it was within the benchmark's noise level.These were the logic changes relative to your PR:
o.c.year > 9999 || o.c.year < 0
than it is to doMath.abs(o.c.year) > 9999
. So we'll squash that bug by-the-by.allowZ
, but that's not actually an option ontoISO
. You always get Z for the UTC zone; the old code hardcoded into the call to the formatter. No real perf difference either way