Skip to content

[3/6] Highlight settings that need attention - #171

Draft
BinaryBearsLLC wants to merge 3 commits into
momenbasel:mainfrom
BinaryBearsLLC:Upgrade-03-settings-attention
Draft

BinaryBearsLLC wants to merge 3 commits into
momenbasel:mainfrom
BinaryBearsLLC:Upgrade-03-settings-attention

Conversation

@BinaryBearsLLC

@BinaryBearsLLC BinaryBearsLLC commented Sep 16, 2026 •

Copy link
Copy Markdown

Part 3 of 6 — depends on #169, #170. Please keep this PR in draft until the preceding parts are merged. Its current Files changed tab includes those earlier changes.

Review and merge order: #169 → #170 → #171 → #172 → #173 → #174.

Before merging: refresh this branch against the updated main, retaining only this part’s commit. If earlier parts were squash-merged or rebased, reapply only the linked commit onto updated main; do not merge the cumulative diff as-is.

Review this part’s commit.

What does this PR do?

Highlights settings that need attention with an amber gear and a gentle pulse. Opening Settings shows the affected items and links to the relevant tab.

  • Covers Full Disk Access, failed login-item changes, a pending language restart and update results.
  • Stops the pulse while Settings is open or the app is inactive, and respects Reduce Motion.

Testing

  • Tested on macOS Ventura 13.6 (22G120, Apple Silicon VM).
  • Host XCTest suite and universal arm64/x86_64 build on macOS 26.6.2.

109 XCTest tests passed, including issue selection and routing; universal build succeeded on macOS 26.6.2 (Apple Silicon). Tested on macOS Ventura 13.6 (22G120, Apple Silicon VM). GUI checks passed for the attention indicator, issue routing, an offline update failure and successful retry after reconnecting.

Screenshots

Settings review items

Sidebar attention

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant