This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
fix: use formdata for all file creation requests #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjmarkham
approved these changes
Nov 11, 2021
samblacklock
changed the title
|
🎉 This PR is included in version 10.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Fix
Fixes a bugDescription
After discussion with API team: ensure that all file creation requests operate with a FormData object.
This way we can maintain the simple
file_locationcreation method by allowing a POJO to be passed without requiring the user to create aFormDataobject of their own (although it doesn't prevent this either)e.g.
Moltin.Files.Create({ file_location: 'https://file-url.com })