Merged
Conversation
25 tasks
68 tasks
midlik
reviewed
Aug 13, 2025
Collaborator
midlik
left a comment
midlik
left a comment
There was a problem hiding this comment.
Thank you, see comments.
| def interpolate( | ||
| self, | ||
| *, | ||
| kind: Literal["vec3"], |
Collaborator
There was a problem hiding this comment.
Don't call it "vec3" if it's for general-length vectors
Member
Author
There was a problem hiding this comment.
it is interpolation of "one or more vec3's", I think the name is fine.
The reason why this is grouped is to be able to introduced "random vectors" as noise (instead of independent components).
Might add the array support for scalars too though.
Comment on lines
+1704
to
+1709
| include_camera: bool = Field( | ||
| default=False, description="Determines whether the camera state should be included in the animation." | ||
| ) | ||
| include_canvas: bool = Field( | ||
| default=False, description="Determines whether the canvas state should be included in the animation." | ||
| ) |
Collaborator
There was a problem hiding this comment.
Why do we need to enable/disable these two specifically?
Member
Author
There was a problem hiding this comment.
- Camera: because sometimes you want the user to be to able to rotate the scene while it's animating
- Canvas: so post-processing etc params are constantly not re-applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
canvas.background_colortransform.local_rotationActions
[Unreleased]section ofCHANGELOG.mdapp/api/examples.pytest-data/notebookswith new featuresdocs