3.12.3 - Issue Resetting Game

[PJNorrisS1]

Hi, I appear to be having the same problem as before. Once a game has finished, we hit the reset game and choose the option to delete players. It just hangs there, and then gives a page error. I have ran it verbose and I don't see anything in the logs. I think we had this issue before. I am up to date on commits... please could you take a look?

Thanks

[eljeffeg]

It could be just a matter of database size. Your browser can timeout before the operation completes on larger sizes. I guess the question is that after giving it time, do the accounts still exist? Is it failing to delete given time?

With regard to performance of the operation, there are a couple things that could be done. The tables that cause the size and performance issue are the snapshot tables. I'd like to remove them and approach it differently, but 1) I didn't develop this piece and I need to learn what is going on 2) it's going to break games that are just trying to update unless I can write a nice SQL migration script. So it would be a 3.x bump for sure, maybe even a 4.0.

[eljeffeg]

The other option would be to create a polling of the status instead of a wait. That would prevent the timeout at least but doesn't address the underlying issue that the snapshots are inefficient and can take a long time to delete.

[PJNorrisS1]

Thanks for replying and looking at options. The container hangs basically. I see no errors and will stay there until I kill and restart the container. Left it hours as well and never recovers.  Something killing it…On 24 Jan 2023, at 23:13, ElJeffe ***@***.***> wrote: It could be just a matter of database size. Your browser can timeout before the operation completes on larger sizes. I guess the question is that after giving it time, do the accounts still exist? Is it failing to delete given time? With regard to performance of the operation, there are a couple things that could be done. The tables that cause the size and performance issue are the snapshot tables. I'd like to remove them and approach it differently, but 1) I didn't develop this piece and I need to learn what is going on 2) it's going to break games that are just trying to update unless I can write a nice SQL migration script. So it would be a 3.x bump for sure. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[eljeffeg]

Give the https://github.com/moloch--/RootTheBox/tree/Truncate_snaps branch a try and let me know if that helps.

[PJNorrisS1]

Noticed when starting up one of the games, i get a lot of this:

rtb-uk-webapp-1     | [I 230127 21:33:52 GameHistory:54] Loading game history from database ...
rtb-uk-webapp-1     | [I 230127 21:33:52 GameHistory:67] Cached snapshot (12963 of 12972)
rtb-uk-webapp-1     | [I 230127 21:34:03 GameHistory:67] Cached snapshot (12964 of 12972)
rtb-uk-webapp-1     | [I 230127 21:34:14 GameHistory:67] Cached snapshot (12965 of 12972)
rtb-uk-webapp-1     | [I 230127 21:34:25 GameHistory:67] Cached snapshot (12966 of 12972)
rtb-uk-webapp-1     | [I 230127 21:34:35 GameHistory:67] Cached snapshot (12967 of 12972)
rtb-uk-webapp-1     | [I 230127 21:34:46 GameHistory:67] Cached snapshot (12968 of 12972)
rtb-uk-webapp-1     | [I 230127 21:34:57 GameHistory:67] Cached snapshot (12969 of 12972)
rtb-uk-webapp-1     | [I 230127 21:35:08 GameHistory:67] Cached snapshot (12970 of 12972)
rtb-uk-webapp-1     | [I 230127 21:35:18 GameHistory:67] Cached snapshot (12971 of 12972)
rtb-uk-webapp-1     | [I 230127 21:35:29 GameHistory:67] Cached snapshot (12972 of 12972)

Do you think this could be part of the problem? I'll try that branch too.

[PJNorrisS1]

Truncate_snaps branch:

rtb-eu-central-webapp-1     | [E 230127 22:11:26 AdminGameHandlers:810] (sqlite3.OperationalError) near "TRUNCATE": syntax error
rtb-eu-central-webapp-1     |     [SQL: TRUNCATE TABLE snapshot_team_to_flag]
rtb-eu-central-webapp-1     |     (Background on this error at: https://sqlalche.me/e/14/e3q8)

[eljeffeg]

Thanks, I've pushed another update to that branch that I hope will fix sqlite.

[PJNorrisS1]

rtb-eu-central-webapp-1     | [I 230128 18:54:50 web:2271] 101 GET /connect/notifications/updates (xxx) 0.58ms
rtb-eu-central-webapp-1     | [E 230128 18:54:55 AdminGameHandlers:810] 'str' object has no attribute 'includes'
rtb-eu-central-webapp-1     | [I 230128 18:54:55 web:2271] 200 POST /admin/resetdelete (xxx) 7.24ms
rtb-eu-central-webapp-1     | [I 230128 18:54:55 web:2271] 101 GET /connect/notifications/updates (xxx) 0.55ms

My current workaround was to export and import to a new DB. Delete players work. Will the cache get full again though?

[eljeffeg]

Ah dangit - brain wrote javascript instead of python. Fixed

[PJNorrisS1]

Tried the latest update... just hangs there as before.

I wonder if this will be an issue going forward? I have a clear cache on my new DB now, and as long as the delete works, will it get in the state it's currently in again?

[PJNorrisS1]

Oh scratch that, it did come back with something:

rtb-eu-central-webapp-1     | [I 230130 15:48:15 web:2271] 101 GET /connect/notifications/updates (xxx) 0.66ms
rtb-eu-central-webapp-1     | [E 230130 15:48:38 AdminGameHandlers:810] (sqlite3.OperationalError) no such table: SQLITE_SEQUENCE
rtb-eu-central-webapp-1     |     [SQL: UPDATE SQLITE_SEQUENCE SET seq = 0 WHERE name = snapshot_team_to_flag]
rtb-eu-central-webapp-1     |     (Background on this error at: https://sqlalche.me/e/14/e3q8)
rtb-eu-central-webapp-1     | [I 230130 15:48:38 web:2271] 200 POST /admin/resetdelete (xxx) 19205.41ms
rtb-eu-central-webapp-1     | [I 230130 15:48:38 web:2271] 101 GET /connect/notifications/updates (xxx) 0.76ms

And the status is

[eljeffeg]

Ok, I've removed that line as it was unnecessary.

[PJNorrisS1]

rtb-eu-central-webapp-1     | [I 230130 17:04:05 web:2271] 101 GET /connect/notifications/updates (xxx) 0.68ms
rtb-eu-central-webapp-1     | [E 230130 17:04:10 AdminGameHandlers:810] (sqlite3.OperationalError) cannot commit - no transaction is active
rtb-eu-central-webapp-1     |     [SQL: COMMIT]
rtb-eu-central-webapp-1     |     (Background on this error at: https://sqlalche.me/e/14/e3q8)
rtb-eu-central-webapp-1     | [I 230130 17:04:10 web:2271] 200 POST /admin/resetdelete (xxx) 11.48ms

[eljeffeg]

Alrighty.. guess I need to install a sqlite instance as I can't seem to get this right with that db. lol

[PJNorrisS1]

I’m happy to share with you the DB if that helps. But need to do it privately.