Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods: fix types for pricing and issuer #374

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

janpaepke
Copy link
Collaborator

When using the method's include option, we expect the result to include a pricing or issuers property, which is an array of objects.

see https://docs.mollie.com/reference/get-method

This replaces #355 and resolves #316

@janpaepke janpaepke requested a review from Pimm September 11, 2024 13:50
@janpaepke janpaepke added the API discrepancy Inconsistency between Mollie's REST API and this SDK. label Sep 11, 2024
@janpaepke janpaepke added this to the 4.0.0 milestone Sep 11, 2024
@janpaepke janpaepke changed the title Fix types for pricing and issuer Methods: fix types for pricing and issuer Sep 11, 2024
Copy link
Collaborator

@Pimm Pimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Pimm Pimm merged commit a678b3a into mollie:master Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API discrepancy Inconsistency between Mollie's REST API and this SDK.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property "issuers" doesn't exist on type "Method"
3 participants