Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Page::count #365

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Remove Page::count #365

merged 1 commit into from
Sep 10, 2024

Conversation

Pimm
Copy link
Collaborator

@Pimm Pimm commented Sep 10, 2024

ECMAScript has a length property which makes count unnecessary. count was deprecated in eb0abd2.

-payments.page({ limit: 10 }).count
+payments.page({ limit: 10 }).length

ECMAScript has a length property which serves this purpose.
@Pimm Pimm merged commit cfc1ef8 into master Sep 10, 2024
5 checks passed
@Pimm Pimm deleted the pimm/dont-count-on-it branch September 10, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants