Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getEntries polyfill (for Object.entries) #352

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Pimm
Copy link
Collaborator

@Pimm Pimm commented Jul 9, 2024

Object.entries is unsupported by Node.js < 7.0.0. We are currently figuring out which Node.js versions 4.0.0 of the client will support, but we plan on raising it to at least 8.0.0. This eliminates the need for a Object.entries polyfill.

Copy link
Collaborator

@dsempel dsempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Object.entries is unsupported by Node.js < 7.0.0. We are currently figuring out which Node.js versions 4.0.0 of the client will support, but we plan on raising it to at least 8.0.0.
@Pimm Pimm force-pushed the pimm/no-object-entries-polyfill branch from 39743e5 to 1c88e74 Compare July 9, 2024 13:33
@Pimm Pimm merged commit c9ccf84 into master Jul 9, 2024
5 checks passed
@Pimm Pimm deleted the pimm/no-object-entries-polyfill branch July 9, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants