Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #292

Merged
merged 5 commits into from
Sep 5, 2022
Merged

Cleanup #292

merged 5 commits into from
Sep 5, 2022

Conversation

Pimm
Copy link
Collaborator

@Pimm Pimm commented Aug 29, 2022

  • Add profileId and testMode to mollieClient.refunds.page and profileId to mollieClient.chargebacks.page.
  • Rename PermissionBinder to PermissionsBinder.
  • Simplify checkId by not relying on it for permissions.
  • Rename data/paymentLink to data/paymentLinks.
  • Rename data/subscription to data/subscriptions.
  • Update documentation.
  • Update enums (adding doenkadotickets and in3).

edorivai
edorivai approved these changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@edorivai edorivai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pimm Pimm merged commit 9b7f987 into master Sep 5, 2022
@Pimm Pimm deleted the pimm/cleanup branch September 5, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edorivai edorivai edorivai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pimm @edorivai