Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug on Node.js < 12 #287

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Fix bug on Node.js < 12 #287

merged 2 commits into from
Sep 9, 2022

Conversation

Pimm
Copy link
Collaborator

@Pimm Pimm commented Aug 1, 2022

Inspecting objects (payments, customers, subscriptions, etc.) would throw an error on Node.js < 12, because the inspect.custom implementation relied on both Object.entries and Object.fromEntries.

@edorivai
Copy link
Collaborator

Approved the change, because the change itself looks good, but did you check for other occurrences of Object.* functions that are not supported by Node <12?

@Pimm
Copy link
Collaborator Author

Pimm commented Aug 29, 2022

I just checked. The only other functions we're using are Object.assign and Object.create, so we should we OK.

We do test on Node.js 6. It just turns out there is no .toString() in the test suite. Come to think of it, I might as well add that.

@Pimm Pimm merged commit 095e1c4 into master Sep 9, 2022
@Pimm Pimm deleted the pimm/old-node-fix branch September 9, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants