Change orderLineCategories in the methods binder to an array #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Mollie API expects a comma-separated list (see https://docs.mollie.com/reference/v2/methods-api/list-methods#parameters). However, an array of strings is the more JavaScript-native type for this, and the NetworkClient will join it anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mollie API expects
orderLineCategoriesin the list methods endpoint to be a comma-separated list. However, an array of strings is the more JavaScript-native type here, and theNetworkClientwill join it anyway.This is not a breaking change, as
orderLineCategorieswas introduced in #279, which has not yet been released.