Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made list the preferred method for endpoints which don't paginate #247

Merged
merged 3 commits into from
Nov 25, 2021

Conversation

Pimm
Copy link
Collaborator

@Pimm Pimm commented Nov 25, 2021

page was selected as the preferred method name over list and all in #234. This PR re-introduces list as the preferred method name for endpoints which don't paginate.

Those endpoints are:

The iterate method does not exist for these endpoints, either.

Copy link
Collaborator

@dsempel dsempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, page is weird if there's only one page.

src/binders/methods/MethodsBinder.ts Outdated Show resolved Hide resolved
src/binders/orders/shipments/OrderShipmentsBinder.ts Outdated Show resolved Hide resolved
@Pimm Pimm merged commit b07c951 into master Nov 25, 2021
@Pimm Pimm deleted the pimm/v3.6.0 branch November 25, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants