New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApiError improvement + fix #236

Merged

Pimm merged 2 commits into master from pimm/error-improvements

Nov 15, 2021

Collaborator

Pimm commented Nov 15, 2021

If an error is thrown where the cause has a response property ‒ probably because it's an AxiosError ‒ the thrown error only uses that response property if it is not undefined. This should reduce the unhelpful 'error without a message' errors by using the message property instead.
Fixed a refactoring mistake I made in Deprecate predictable helper methods #233. (Luckily, I can put some of the blame on my IDE.)

Pimm added 2 commits

November 15, 2021 08:40


          Change error generation logic, to increase the chances of getting a h…

41ffd3e

…elpful error message.


          Fix bug related to errors I introduced in eb0abd2.

d3e5c68

dsempel approved these changes

View reviewed changes

Pimm merged commit 5a1d556 into master

Pimm deleted the pimm/error-improvements branch

November 15, 2021 13:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet