Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed (inner) binders #226

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Renamed (inner) binders #226

merged 1 commit into from
Sep 28, 2021

Conversation

Pimm
Copy link
Collaborator

@Pimm Pimm commented Sep 28, 2021

ordersPayments (previously orders_payments) is renamed to orderPayments. (And customersSubscriptions to customerSubscriptions, paymentsCaptures to paymentCaptures et cetera.)

This name:

  • is consistent with the PHP client ($orderPayments),
  • better describes the contents (the payments for one order; rather than the payments for multiple/all orders),
  • is one character shorter, saving precious seconds.

@Pimm
Rename (inner) binders.
e7f57a6 
ordersPayments (previously orders_payments) → orderPayments. This name is consistent with the PHP client ($orderPayments), and it also better describes the contents (the payments for one order).
@Pimm Pimm merged commit e818355 into master Sep 28, 2021
@Pimm Pimm deleted the pimm/v3.6.0 branch September 28, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edorivai edorivai edorivai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pimm @edorivai