Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Node.js URL API for WHATWG URL API. #196

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Conversation

Pimm
Copy link
Collaborator

@Pimm Pimm commented Jan 28, 2021

The Node.js URL API was deprecated in Node.js 11, while the WHATWG counterpart is supported since Node.js 7 and 6.13.

Our lowest supported Node.js version is currently 6.14.

The Node.js URL API was deprecated in Node.js 11, while the WHATWG counterpart is supported since Node.js 7 and 6.13. (Our lowest supported Node.js version is currently 6.14.)
src/resources/Resource.ts Outdated Show resolved Hide resolved
@Pimm Pimm requested a review from edorivai January 28, 2021 15:50
Copy link
Collaborator

@edorivai edorivai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Pimm Pimm merged commit 9e8cb72 into master Jan 29, 2021
@Pimm Pimm deleted the pimm/whatwg-url-api branch January 29, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants