-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support applepay validation #193
Conversation
@Pimm - Are you the best person to request a review from? |
… closer follow the terminology of the Mollie API as well as Apple. See https://docs.mollie.com/reference/v2/wallets-api/request-apple-pay-payment-session and https://developer.apple.com/documentation/apple_pay_on_the_web/apple_pay_js_api/requesting_an_apple_pay_payment_session.
For this specific endpoint, the Mollie API does not return a normal Mollie-style model.
@Pimm - Thanks so much for looking at this so quickly. |
Thank you for the contribution! I changed your PR in two ways:
It is unfortunate that we can't test this in the way we test the other endpoints. |
Awesome, thanks so much @Pimm. Do you think this will make it's way into your next release? |
Yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edorivai - good idea. I'll be using it with our Mollie / Deity (https://deity.io/) integration so it should get heavily tested. |
To hopefully make your job slightly easier, you can now use the version with the Should you run into any issues while integrating Mollie ‒ including anything not Apple Pay related ‒ please let me know. |
@Pimm I've put live ApplePay transactions through Mollie using the beta branch so I can confirm it works :-) |
I've tried to add support for the ApplePay session method - https://docs.mollie.com/reference/v2/wallets-api/request-apple-pay-payment-session
I've not been able to test because this method is not available in test mode.
I'd love some feedback if you're able to provide it