Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to orders.update #173

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

Pimm
Copy link
Collaborator

@Pimm Pimm commented Oct 14, 2020

According to the documentation, it is possible to update the redirect and webhook URLs for orders. Therefore, the associated properties are now included in the parameters type.

Fixes #169.

Copy link
Collaborator

@dsempel dsempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I guess this was already possible to do, but the types were just not up to date?

@Pimm Pimm force-pushed the pimm/update-order-parameters branch from 95d3e9f to a0457df Compare October 14, 2020 11:29
@Pimm
Copy link
Collaborator Author

Pimm commented Oct 14, 2020

Exactly. It doesn't seem like this was added recently, either. I think this has simply been missing from the types.

@Pimm Pimm merged commit 39202db into master Oct 14, 2020
@Pimm Pimm deleted the pimm/update-order-parameters branch October 14, 2020 11:31
@Pimm Pimm mentioned this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect url including order id
2 participants