Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kind-of dependency to fix security vulnerability #158

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

vernondegoede
Copy link
Contributor

@vernondegoede vernondegoede commented Jul 7, 2020

This fixes GHSA-6c8f-qphg-qjgp.

Unfortunately, not all dependencies have released new versions that depend on the latest version of the kind-of dependency. Therefore, I suggest fixing this using selective dependency resolutions.

We should plan a moment to revisit all dependencies and upgrade the ones that released a patch. This will most likely allow us to clean up the other selective dependency resolutions as well.

@vernondegoede vernondegoede requested a review from Pimm July 7, 2020 06:12
@CosmaTrix
Copy link

CosmaTrix commented Jul 7, 2020

Instead of installing kind-of manually to bump its version, I'd use Selective dependency resolutions. That is a clean way to upgrade a sub-dependency without waiting for another direct-dependency to upgrade.

https://classic.yarnpkg.com/en/docs/selective-version-resolutions/

@CosmaTrix
Copy link

Oh, right! I didn't expand the package.json and I thought those were devDependencies. 🤦

@vernondegoede vernondegoede merged commit a327e6b into master Jul 7, 2020
@vernondegoede vernondegoede deleted the vernon/upgrade-kind-of-dependency branch July 7, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants