DASH-1618 - Fix vulnerability alerts #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvgunst
reviewed
Mar 26, 2019
| @@ -32,39 +32,38 @@ | |||
| "test:unit:cov": "jest ./tests/unit --coverage", | |||
| "build": "rollup -c", | |||
| "lint:prettier": "prettier --write \"{src,tests,examples}/**/*.js\"", | |||
| "lint:eslint": "eslint {src,test,examples}/**/*.js", | |||
| "lint:eslint": "eslint {src,tests}/**/*.js", | |||
There was a problem hiding this comment.
Why did you remove the examples directory? Shouldn't we run Eslint on the examples?
There was a problem hiding this comment.
The examples have a lot of unused constants, which are only there for example purposes. I believe running Prettier on the examples will be sufficient.
lvgunst
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently 10 vulnerability alerts for the Node API module. I've upgraded most of our dependencies (they were quite outdated) and now most of them are gone.
Unfortunately, we need to drop support for Node 4.8 since we have updated ESLint. However, as we already discussed in our TypeScript migration PR (#97), this doesn't have to be a breaking change as it's not used that much.
Last week another advisory was published, but I need to wait for my ESLint PR to be approved & released before we can fix that alert as well.
Release strategy
Before actually releasing this, I'd like to release a beta version of the API client to test it in some example projects.