Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge schemas #1172

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Fix merge schemas #1172

merged 3 commits into from
Jan 2, 2023

Conversation

0x0a0d
Copy link
Contributor

@0x0a0d 0x0a0d commented Dec 28, 2022

if mixinSchema is null, res[key] will throw error
if svcSchema is null, Object.keys(mods) will throw error

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@icebob icebob merged commit da22552 into moleculerjs:master Jan 2, 2023
@0x0a0d 0x0a0d deleted the fix-mergeSchemas branch January 9, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants