Skip to content

Commit

Permalink
test: cover protobuf
Browse files Browse the repository at this point in the history
  • Loading branch information
@icebob
icebob committed Apr 21, 2017
1 parent e038a49 commit fc14ed4
Show file tree
Hide file tree
Showing 9 changed files with 324 additions and 140 deletions.
2 changes: 1 addition & 1 deletion benchmark/perf-runner.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ let [b1, b2] = createBrokers(Transporters.Fake);
let count = 0;
function doRequest() {
count++;
return b2.call("echo.reply", { a: count }).then(res => {
return b1.call("echo.reply", { a: count }).then(res => {
if (count % 10000) {
// Fast cycle
doRequest();
Expand Down
243 changes: 145 additions & 98 deletions benchmark/suites/serializers.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ function runTest(dataName) {
let brokerJSON = createBrokers(Serializers.JSON);
let brokerAvro = createBrokers(Serializers.Avro);
let brokerMsgPack = createBrokers(Serializers.MsgPack);
let brokerProtoBuf = createBrokers(Serializers.ProtoBuf);

let bench1 = benchmark.createSuite(`Serialize event packet with ${dataName}bytes`);

Expand All @@ -48,6 +49,11 @@ function runTest(dataName) {
const packet = new P.PacketEvent(brokerMsgPack.transit, "user.created", payload);
return packet.serialize();
});

bench1.add("ProtoBuf", () => {
const packet = new P.PacketEvent(brokerProtoBuf.transit, "user.created", payload);
return packet.serialize();
});

let bench2 = benchmark.createSuite(`Serialize request packet with ${dataName}bytes`);

Expand All @@ -62,6 +68,7 @@ function runTest(dataName) {
console.log("JSON length:", (new P.PacketRequest(brokerJSON.transit, "node-2-12345", ctx)).serialize().length);
console.log("Avro length:", (new P.PacketRequest(brokerAvro.transit, "node-2-12345", ctx)).serialize().length);
console.log("MsgPack length:", (new P.PacketRequest(brokerMsgPack.transit, "node-2-12345", ctx)).serialize().length);
console.log("ProtoBuf length:", (new P.PacketRequest(brokerProtoBuf.transit, "node-2-12345", ctx)).serialize().length);

bench2.ref("JSON", () => {
const packet = new P.PacketRequest(brokerJSON.transit, "node-2-12345", ctx);
Expand All @@ -77,6 +84,11 @@ function runTest(dataName) {
const packet = new P.PacketRequest(brokerMsgPack.transit, "node-2-12345", ctx);
return packet.serialize();
});

bench2.add("ProtoBuf", () => {
const packet = new P.PacketRequest(brokerProtoBuf.transit, "node-2-12345", ctx);
return packet.serialize();
});

return bench1.run()
.then(() => bench2.run())
Expand Down Expand Up @@ -105,162 +117,197 @@ Platform info:
JSON length: 177
Avro length: 75
MsgPack length: 137
ProtoBuf length: 82
Suite: Serialize event packet with 10bytes
√ JSON 1,124,939 rps
√ Avro 925,157 rps
√ MsgPack 99,040 rps
JSON (#) 0% (1,124,939 rps) (avg: 888ns)
Avro -17.76% (925,157 rps) (avg: 1μs)
MsgPack -91.2% (99,040 rps) (avg: 10μs)
√ JSON 1,127,978 rps
√ Avro 921,266 rps
√ MsgPack 98,007 rps
√ ProtoBuf 826,795 rps
JSON (#) 0% (1,127,978 rps) (avg: 886ns)
Avro -18.33% (921,266 rps) (avg: 1μs)
MsgPack -91.31% (98,007 rps) (avg: 10μs)
ProtoBuf -26.7% (826,795 rps) (avg: 1μs)
-----------------------------------------------------------------------
Suite: Serialize request packet with 10bytes
√ JSON 615,732 rps
√ Avro 579,453 rps
√ MsgPack 55,954 rps
JSON (#) 0% (615,732 rps) (avg: 1μs)
Avro -5.89% (579,453 rps) (avg: 1μs)
MsgPack -90.91% (55,954 rps) (avg: 17μs)
√ JSON 621,247 rps
√ Avro 585,392 rps
√ MsgPack 53,962 rps
√ ProtoBuf 476,540 rps
JSON (#) 0% (621,247 rps) (avg: 1μs)
Avro -5.77% (585,392 rps) (avg: 1μs)
MsgPack -91.31% (53,962 rps) (avg: 18μs)
ProtoBuf -23.29% (476,540 rps) (avg: 2μs)
-----------------------------------------------------------------------
JSON length: 331
Avro length: 216
MsgPack length: 278
ProtoBuf length: 223
Suite: Serialize event packet with 150bytes
√ JSON 460,613 rps
√ Avro 358,995 rps
√ MsgPack 86,702 rps
JSON (#) 0% (460,613 rps) (avg: 2μs)
Avro -22.06% (358,995 rps) (avg: 2μs)
MsgPack -81.18% (86,702 rps) (avg: 11μs)
√ JSON 461,563 rps
√ Avro 351,653 rps
√ MsgPack 80,712 rps
√ ProtoBuf 377,706 rps
JSON (#) 0% (461,563 rps) (avg: 2μs)
Avro -23.81% (351,653 rps) (avg: 2μs)
MsgPack -82.51% (80,712 rps) (avg: 12μs)
ProtoBuf -18.17% (377,706 rps) (avg: 2μs)
-----------------------------------------------------------------------
Suite: Serialize request packet with 150bytes
√ JSON 341,672 rps
√ Avro 292,635 rps
√ MsgPack 49,990 rps
JSON (#) 0% (341,672 rps) (avg: 2μs)
Avro -14.35% (292,635 rps) (avg: 3μs)
MsgPack -85.37% (49,990 rps) (avg: 20μs)
√ JSON 346,086 rps
√ Avro 292,872 rps
√ MsgPack 44,776 rps
√ ProtoBuf 277,967 rps
JSON (#) 0% (346,086 rps) (avg: 2μs)
Avro -15.38% (292,872 rps) (avg: 3μs)
MsgPack -87.06% (44,776 rps) (avg: 22μs)
ProtoBuf -19.68% (277,967 rps) (avg: 3μs)
-----------------------------------------------------------------------
JSON length: 1301
Avro length: 1118
MsgPack length: 1181
ProtoBuf length: 1125
Suite: Serialize event packet with 1kbytes
√ JSON 123,840 rps
√ Avro 105,663 rps
√ MsgPack 59,347 rps
JSON (#) 0% (123,840 rps) (avg: 8μs)
Avro -14.68% (105,663 rps) (avg: 9μs)
MsgPack -52.08% (59,347 rps) (avg: 16μs)
√ JSON 122,647 rps
√ Avro 104,191 rps
√ MsgPack 57,945 rps
√ ProtoBuf 141,024 rps
JSON (#) 0% (122,647 rps) (avg: 8μs)
Avro -15.05% (104,191 rps) (avg: 9μs)
MsgPack -52.75% (57,945 rps) (avg: 17μs)
ProtoBuf +14.98% (141,024 rps) (avg: 7μs)
-----------------------------------------------------------------------
Suite: Serialize request packet with 1kbytes
√ JSON 114,891 rps
√ Avro 99,964 rps
√ MsgPack 38,987 rps
JSON (#) 0% (114,891 rps) (avg: 8μs)
Avro -12.99% (99,964 rps) (avg: 10μs)
MsgPack -66.07% (38,987 rps) (avg: 25μs)
√ JSON 112,659 rps
√ Avro 99,252 rps
√ MsgPack 38,276 rps
√ ProtoBuf 121,798 rps
JSON (#) 0% (112,659 rps) (avg: 8μs)
Avro -11.9% (99,252 rps) (avg: 10μs)
MsgPack -66.02% (38,276 rps) (avg: 26μs)
ProtoBuf +8.11% (121,798 rps) (avg: 8μs)
-----------------------------------------------------------------------
JSON length: 11344
Avro length: 10516
MsgPack length: 10578
ProtoBuf length: 10522
Suite: Serialize event packet with 10kbytes
√ JSON 15,396 rps
√ Avro 13,895 rps
√ MsgPack 16,661 rps
JSON (#) 0% (15,396 rps) (avg: 64μs)
Avro -9.75% (13,895 rps) (avg: 71μs)
MsgPack +8.22% (16,661 rps) (avg: 60μs)
√ JSON 14,996 rps
√ Avro 13,267 rps
√ MsgPack 14,009 rps
√ ProtoBuf 21,902 rps
JSON (#) 0% (14,996 rps) (avg: 66μs)
Avro -11.53% (13,267 rps) (avg: 75μs)
MsgPack -6.58% (14,009 rps) (avg: 71μs)
ProtoBuf +46.05% (21,902 rps) (avg: 45μs)
-----------------------------------------------------------------------
Suite: Serialize request packet with 10kbytes
√ JSON 15,284 rps
√ Avro 13,933 rps
√ MsgPack 14,620 rps
JSON (#) 0% (15,284 rps) (avg: 65μs)
Avro -8.84% (13,933 rps) (avg: 71μs)
MsgPack -4.34% (14,620 rps) (avg: 68μs)
√ JSON 15,310 rps
√ Avro 12,822 rps
√ MsgPack 12,595 rps
√ ProtoBuf 20,763 rps
JSON (#) 0% (15,310 rps) (avg: 65μs)
Avro -16.25% (12,822 rps) (avg: 77μs)
MsgPack -17.73% (12,595 rps) (avg: 79μs)
ProtoBuf +35.61% (20,763 rps) (avg: 48μs)
-----------------------------------------------------------------------
JSON length: 54317
Avro length: 50589
MsgPack length: 50651
ProtoBuf length: 50596
Suite: Serialize event packet with 50kbytes
√ JSON 3,332 rps
√ Avro 3,014 rps
√ MsgPack 3,680 rps
JSON (#) 0% (3,332 rps) (avg: 300μs)
Avro -9.53% (3,014 rps) (avg: 331μs)
MsgPack +10.44% (3,680 rps) (avg: 271μs)
√ JSON 3,319 rps
√ Avro 2,893 rps
√ MsgPack 3,657 rps
√ ProtoBuf 4,549 rps
JSON (#) 0% (3,319 rps) (avg: 301μs)
Avro -12.83% (2,893 rps) (avg: 345μs)
MsgPack +10.19% (3,657 rps) (avg: 273μs)
ProtoBuf +37.06% (4,549 rps) (avg: 219μs)
-----------------------------------------------------------------------
Suite: Serialize request packet with 50kbytes
√ JSON 3,309 rps
√ Avro 2,886 rps
√ MsgPack 3,507 rps
JSON (#) 0% (3,309 rps) (avg: 302μs)
Avro -12.79% (2,886 rps) (avg: 346μs)
MsgPack +5.97% (3,507 rps) (avg: 285μs)
√ JSON 3,307 rps
√ Avro 2,872 rps
√ MsgPack 3,478 rps
√ ProtoBuf 4,527 rps
JSON (#) 0% (3,307 rps) (avg: 302μs)
Avro -13.14% (2,872 rps) (avg: 348μs)
MsgPack +5.19% (3,478 rps) (avg: 287μs)
ProtoBuf +36.89% (4,527 rps) (avg: 220μs)
-----------------------------------------------------------------------
JSON length: 108442
Avro length: 101088
MsgPack length: 101152
ProtoBuf length: 101095
Suite: Serialize event packet with 100kbytes
√ JSON 1,685 rps
√ Avro 1,470 rps
√ MsgPack 1,924 rps
JSON (#) 0% (1,685 rps) (avg: 593μs)
Avro -12.73% (1,470 rps) (avg: 680μs)
MsgPack +14.18% (1,924 rps) (avg: 519μs)
√ JSON 1,679 rps
√ Avro 1,462 rps
√ MsgPack 1,936 rps
√ ProtoBuf 2,325 rps
JSON (#) 0% (1,679 rps) (avg: 595μs)
Avro -12.97% (1,462 rps) (avg: 684μs)
MsgPack +15.26% (1,936 rps) (avg: 516μs)
ProtoBuf +38.42% (2,325 rps) (avg: 430μs)
-----------------------------------------------------------------------
Suite: Serialize request packet with 100kbytes
√ JSON 1,684 rps
√ Avro 1,470 rps
√ MsgPack 1,902 rps
JSON (#) 0% (1,684 rps) (avg: 593μs)
Avro -12.66% (1,470 rps) (avg: 680μs)
MsgPack +12.99% (1,902 rps) (avg: 525μs)
√ JSON 1,683 rps
√ Avro 1,464 rps
√ MsgPack 1,890 rps
√ ProtoBuf 2,357 rps
JSON (#) 0% (1,683 rps) (avg: 594μs)
Avro -13% (1,464 rps) (avg: 682μs)
MsgPack +12.32% (1,890 rps) (avg: 529μs)
ProtoBuf +40.08% (2,357 rps) (avg: 424μs)
-----------------------------------------------------------------------
JSON length: 1082692
Avro length: 1010070
MsgPack length: 1010134
ProtoBuf length: 1010077
Suite: Serialize event packet with 1Mbytes
√ JSON 158 rps
√ Avro 131 rps
√ MsgPack 193 rps
JSON (#) 0% (158 rps) (avg: 6ms)
Avro -17.1% (131 rps) (avg: 7ms)
MsgPack +22.11% (193 rps) (avg: 5ms)
√ JSON 158 rps
√ Avro 131 rps
√ MsgPack 191 rps
√ ProtoBuf 193 rps
JSON (#) 0% (158 rps) (avg: 6ms)
Avro -17.29% (131 rps) (avg: 7ms)
MsgPack +21.13% (191 rps) (avg: 5ms)
ProtoBuf +22.28% (193 rps) (avg: 5ms)
-----------------------------------------------------------------------
Suite: Serialize request packet with 1Mbytes
√ JSON 158 rps
√ Avro 131 rps
√ MsgPack 192 rps
JSON (#) 0% (158 rps) (avg: 6ms)
Avro -16.81% (131 rps) (avg: 7ms)
MsgPack +22.21% (192 rps) (avg: 5ms)
√ JSON 157 rps
√ Avro 131 rps
√ MsgPack 190 rps
√ ProtoBuf 192 rps
JSON (#) 0% (157 rps) (avg: 6ms)
Avro -16.91% (131 rps) (avg: 7ms)
MsgPack +21.22% (190 rps) (avg: 5ms)
ProtoBuf +22.22% (192 rps) (avg: 5ms)
-----------------------------------------------------------------------
*/
3 changes: 2 additions & 1 deletion src/serializers/avro.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ schemas[P.PACKET_RESPONSE] = avro.Type.forSchema({
{ name: "name", type: "string" },
{ name: "message", type: "string" },
{ name: "code", type: "int" },
{ name: "data", type: "string" }
{ name: "data", type: "string" },
{ name: "nodeID", type: "string" }
]
} ], default: null }
]
Expand Down
3 changes: 2 additions & 1 deletion src/serializers/proto/packets.proto
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,15 @@ message PacketResponse {
required string sender = 1;
required string id = 2;
required bool success = 3;
required string data = 4;
optional string data = 4;
optional Error error = 5;

message Error {
required string name = 1;
required string message = 2;
required int32 code = 3;
required string data = 4;
required string nodeID = 5;
}
}

Expand Down
Loading

0 comments on commit fc14ed4

Please sign in to comment.