Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Webpack config #61

Merged
merged 15 commits into from
Jun 29, 2017
Merged

Update Webpack config #61

merged 15 commits into from
Jun 29, 2017

Conversation

codeithuman
Copy link
Contributor

@codeithuman codeithuman commented Jun 28, 2017 •
edited
Loading

This PR adds Webpack and removes Brunch. With Webpack assets are built correctly for import from the NPM package.

Fixes #59.

zberkom
zberkom approved these changes Jun 28, 2017
View reviewed changes
Copy link
Contributor

@zberkom zberkom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @codeithuman!

@zberkom
Copy link
Contributor

zberkom commented Jun 29, 2017

I'm going to merge this, since it's blocking other additions I'd like to do.

@zberkom zberkom merged commit a0973b4 into master Jun 29, 2017
@zberkom zberkom deleted the feature/add-webpack-remove-brunch branch June 29, 2017 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zberkom zberkom zberkom approved these changes

@darinwilson darinwilson Awaiting requested review from darinwilson

@danielberkompas danielberkompas Awaiting requested review from danielberkompas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codeithuman @zberkom