fix matching for setting active navbar link

[RVRX]

Quick fix for a minor visual issue where any link with a name that is a subset of the current active link will also be set as active, as the previous regex statement was matching anything that contained said string.

---

Bug Example

When "developer_user" is the active link, any tabs with a name contained in that string will also be highlighted, i.e. "user"

Fix

Converts the navbar link into a full link path and compares against the current URL.

This should also work no-matter how the end-user defines their navbar link, be it:

<a href="users">Users</a>
<a href="/users">Users</a>
<a href="some/path/users">Users</a>
<a href="http://example.com/admin/users">Users</a>

Note: I am making the assumption in this PR that the URL in the Torch NavBar will always end in the same value as the current URL, i.e. .../admin/developer_user or .../admin/developer_user/ not .../admin/developer_user#anchor. It should however, handle query parameters fine if those were present for whatever reason.

[cpjolicoeur]

@RVRX can we just skip creating another temporary variable here and just use the getAttribute directly inside this new URL() call?

const linkTarget = new URL(field.getAttribute('href'), document.BaseURI).href

Also, what about using startsWith() for the comparison vs ===. Would that negate any issues with the string ending with/starting with specific string values (anchors, query string, etc...)?

[RVRX]

Yup good call, that deals with query params and anchors concisely. Committed both changes as requested.

[cpjolicoeur]

Thanks @RVRX

[cpjolicoeur]

@RVRX Version 4.2.0 was released which includes this change.

[cpjolicoeur]

@RVRX I was made aware we didnt compile the assets in the 4.2 release. I'm going to update that now, release 4.2.1 and then pull the 4.2.0 release when done. Standby

[cpjolicoeur]

@RVRX version 4.2.1 released with the updated assets included