-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert support for phoenix 1.6 from the master branch #287
Conversation
e668aac
to
b78afbd
Compare
@chewnoill see my note here regarding Torch 3/4 and branching: #286 (comment) |
b78afbd
to
0e75d42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chewnoill as part of this PR can we update the README to include copy/notes that Torch 3/mainline only supports Phx 1.5 and below, and then also point people to the v4
branch for Phx 1.6+ support.
85acf5f
to
4df7aa7
Compare
elixir 1.10 builds are failing now, Not sure what changed here:
|
4df7aa7
to
b094e31
Compare
I merged this earlier: #285 I didn't notice in the changelog that it ways 0.28.0 requires Elixir 1.10+. I'll revert that PR and then you can rebase. |
README.md
Outdated
@@ -5,6 +5,10 @@ | |||
|
|||
# Torch | |||
|
|||
> This version of torch (3.x) only supports phoenix 1.5 and below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos here. "Torch" and "Phoenix"
b094e31
to
3bdfdda
Compare
ok @chewnoill #288 merged. you can rebase this now |
This reverts commit bbb7d9a.
3bdfdda
to
97ffb7f
Compare
Torch won't support phoenix 1.6 officially until 4.0