add locale vi translation #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpjolicoeur
requested changes
Jan 11, 2021
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: 8bit\n" | ||
| "Language: en\n" |
There was a problem hiding this comment.
@nhphuc412 I believe this is incorrect. This isn't an "en" (English) translation file. If you can update this value to the proper locale entry for the included Vietnamese translations and update this commit we can get this merged in and a new release pushed out.
Thanks.
There was a problem hiding this comment.
@cpjolicoeur I updated value for vietnamese translations
|
@nhphuc412 Thanks so much for the contribution! Just one small update I believe is needed and then we can merge this in. |
|
@nhphuc412 Thanks so much for the work on this. Torch v3.6.0 was released today and includes your VI locale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.