Fix disabled inputs and prep for 2.0.0-rc2 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously form `input` and `select` fields were being disabled, regardless of whether the form was being submitted or not. This means, in case of "validation" failure, the form wasn't submitted, but empty `input` and `select` fields were now disabled and couldn't be edited to bring them into a proper, submittable "valid" state.
PostgreSQL is needed for the Phoenix integation test examples and needs to be running and configured for Travis to build successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings over a few commits from the MojoTech fork as well as updates the changelog and travis config in prep for the v2.0.0-rc2 release