Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Alignment Broken in Safari? #394

Closed
ladygeekgeek opened this issue Feb 9, 2015 · 12 comments
Closed

Vertical Alignment Broken in Safari? #394

ladygeekgeek opened this issue Feb 9, 2015 · 12 comments
Labels

Comments

@ladygeekgeek
Copy link

Hi there - can't seem to get align() to work in safari - is this a known bug? Have a look at this codepen on safari versus chrome.
http://codepen.io/SitePoint/pen/ogWpyd

Thanks

@martinsmith
Copy link

BUMP - Coincidentally just stumbled on this problem myself :/

@jakecleary
Copy link
Contributor

Hi @ladygeekgeek, @martinsmith,

This seems to be because your CSS isn't being prefixed. If you look at this page you'll see that Safari requires the -webkit- prefix to understand 2D transforms.

I would recommend using something like autoprefixer for this. It will autoprefix your CSS based on browser support that you can specify.

Are you using Grunt/Gulp or anything like that? It will make it easy to integrate an autoprefixer into your workflow.

@jakecleary jakecleary removed the bug label Feb 10, 2015
@samccone
Copy link
Contributor

👍 good call @jakecleary

I will close for now, unless we isolate to jeet

@ladygeekgeek
Copy link
Author

Thanks Jake - but that's just calling the Jeet mixin - so maybe they need to fix their code to include the safari prefix? The codepen is just an example of how to use Jeet (it's not my code).

@ladygeekgeek
Copy link
Author

I'm importing Jeet via codekit.

@microcipcip
Copy link

Do you have autoprefixer enabled on Codekit then?

@ladygeekgeek
Copy link
Author

Hmm - I use compass - so assumed that sorts my own prefixes.

@microcipcip
Copy link

AFAIK Compass will add the prefixes just for specific compass functions, Jeet is not a Compass extension so I guess it won't have prefixes added there.

@jakecleary
Copy link
Contributor

Hi @ladygeekgeek,

In codepen if you click on the CSS option cog you can enable autoprefixer. This will fix it for you 😄

screenshot 2015-02-10 17 33 26

@martinsmith
Copy link

Hi there! Thanks for looking into this - apologies for not even considering Autoprefix :( I can confirm this fixes the issue. @ladygeekgeek, in Codekit select your .scss (or styl, or sass) file and a side panel will appear. Click the Autoprefixer checkbox, recompile and bobs your uncle!

@ladygeekgeek
Copy link
Author

Thanks everyone for your help - I'll switch on autoprefixer - but perhaps this should be mentioned somewhere in the Jeet documentation.

samccone added a commit that referenced this issue Feb 11, 2015
@samccone
Copy link
Contributor

@ladygeekgeek thanks for the feedback! I have opened a PR to do just that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants