Resolves #872: Make allowSnapshots an explicit argument in lookupDependencyUpdates and in reports #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slawekjaranowski please review |
andrzejj0
force-pushed
the
issue-872-allow-snapshots-not-respected
branch
2 times, most recently
from
0818123 to
36633cc
Compare
versions-common/src/main/java/org/codehaus/mojo/versions/api/ArtifactVersions.java
Show resolved
Hide resolved
versions-common/src/main/java/org/codehaus/mojo/versions/api/ArtifactVersions.java
Show resolved
Hide resolved
versions-common/src/main/java/org/codehaus/mojo/versions/api/ArtifactVersions.java
Outdated
Show resolved
Hide resolved
versions-common/src/test/java/org/codehaus/mojo/versions/api/ArtifactVersionsTest.java
Outdated
Show resolved
Hide resolved
versions-common/src/test/java/org/codehaus/mojo/versions/api/ArtifactVersionsTest.java
Show resolved
Hide resolved
andrzejj0
force-pushed
the
issue-872-allow-snapshots-not-respected
branch
4 times, most recently
from
68ef3c5 to
904dd11
Compare
versions-enforcer/src/main/java/org/apache/maven/plugins/enforcer/MaxDependencyUpdates.java
Outdated
Show resolved
Hide resolved
…okupDependencyUpdates and in reports
andrzejj0
force-pushed
the
issue-872-allow-snapshots-not-respected
branch
from
904dd11 to
f1b3894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowSnapshots was not an explicit argument in many retrieval operations. Instead, it was assumed that the user would call
AbstractVersionDetails.setIncludeSnapshots()to set it. This class was used as a container for this value so that it could be passed to report generators.So, I'm clearing this up and also passing the value explicitly where needed.