Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification in README - maintained versions, issues and PR creation #832

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

slawekjaranowski
Copy link
Member

According to clarification we can only test with the latest Maven on GitHub it will save time for executing

According to clarification we can only test with the latest Maven on GitHub
it will save time for executing
@slawekjaranowski
Copy link
Member Author

What do you think @slachiewicz, @stefanseifert, @ajarmoniuk, @sultan

@sultan
Copy link
Contributor

sultan commented Nov 26, 2022

i would say let's move forward and be clear on the minimal maven version needed to run the plugin.
any chance we move to maven 4 when available?

@andrzejj0
Copy link
Contributor

I think we need to check the minimal version supported as well as a current version - which can be the latest release or some other one we choose. But without testing with the minimal version we can not be sure if we really support it.

@slachiewicz
Copy link
Member

Maybe we should explicitly say that we recommend Maven 3.8.6 (plus link) and add note to verify if issue can be reproduced also with latest version of Maven

@slawekjaranowski
Copy link
Member Author

i would say let's move forward and be clear on the minimal maven version needed to run the plugin. any chance we move to maven 4 when available?

Maven 4 API is not compatible backward to Maven 3, so it is for discussion later.

@slawekjaranowski
Copy link
Member Author

I think we need to check the minimal version supported as well as a current version - which can be the latest release or some other one we choose. But without testing with the minimal version we can not be sure if we really support it.

I know that when we will testing only with latest versions of Maven some of issue can be detected.

But only checking minimum version doesn't make us sure that will be work with all other older versions like 3.3.x, 3.5.x, 3.6.x

When someone detect an issue with Maven 3.5.x - I want not spend time for resolving it.

@slawekjaranowski
Copy link
Member Author

Maybe we should explicitly say that we recommend Maven 3.8.6 (plus link) and add note to verify if issue can be reproduced also with latest version of Maven

Exactly it is my idea and my proposition in change.

@andrzejj0
Copy link
Contributor

I think we need to check the minimal version supported as well as a current version - which can be the latest release or some other one we choose. But without testing with the minimal version we can not be sure if we really support it.

I know that when we will testing only with latest versions of Maven some of issue can be detected.

But only checking minimum version doesn't make us sure that will be work with all other older versions like 3.3.x, 3.5.x, 3.6.x

When someone detect an issue with Maven 3.5.x - I want not spend time for resolving it.

Fair enough, I think you're right.

@slawekjaranowski slawekjaranowski added this to the 2.14.0 milestone Dec 1, 2022
@slawekjaranowski slawekjaranowski merged commit 9576c2e into master Dec 1, 2022
@slawekjaranowski slawekjaranowski deleted the clarification-readme branch December 1, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants